Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-20.0] Bugfix/3993/fix flickering unread mention popup #4189

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Sep 11, 2024

Backport of PR #4177

bug was introduced with #3417

Signed-off-by: Marcel Hibbe <[email protected]>
… null

same for swipeRefreshLayoutView?.isRefreshing

If searchHelper would be null (= when UnifiedSearch is not available) then going back to conversations list view would not trigger to check to show for unread mentions bubble. This fix will make it independent from searchHelper.

Signed-off-by: Marcel Hibbe <[email protected]>
… button

...instead to just show it on top

Signed-off-by: Marcel Hibbe <[email protected]>
@backportbot backportbot bot added the 3. to review Waiting for reviews label Sep 11, 2024
@backportbot backportbot bot added this to the 20.0.0 milestone Sep 11, 2024
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings8692
Errors131131

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code7878
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total108108

Lint increased!

Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4189-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi merged commit e492d32 into stable-20.0 Sep 11, 2024
12 of 15 checks passed
@mahibi mahibi deleted the backport/4177/stable-20.0 branch September 11, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant